-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][ci] Fix OWASP Dependency Check download by using NVD API key #4473
Conversation
6883c1d
to
608a149
Compare
@lhotari It seems download is still failed, do we need to merge this first? |
Yes. Another option would be to create the PR branch to apache/bookkeeper so that it has access to the secret. The dependency check version must be at least 10.0.2 (there's another Pulsar PR explaining that). |
608a149
to
f4b76c0
Compare
@lhotari Thanks, I see your description in apache/pulsar#23012. I suggest we can merge this pr first.
|
That works for me, but why not just upgrade to 10.0.2 in this PR? |
Looks like 10.0.2 is used in this PR, LGTM. |
There's a error building the docker image
I believe |
Signed-off-by: ZhangJian He <[email protected]>
f4b76c0
to
1de5bb3
Compare
See more in apache/pulsar#22999. Thanks for @lhotari
INFRA-TICKET https://issues.apache.org/jira/projects/INFRA/issues/INFRA-26000